Hm, for me, I usually lean towards the water starter or the grass, although, for X/Y I went with the fire starter.
I tend to just go with the one I feel is the cutest. I'm actually pretty casual when it comes to Pokemon. Most people are all about stats and EV and IV or whatever you call it (and I still don't understand it), but for me, I go with the one that's aesthetically pleasing to my eye.
Let's go with the original three from Red/Blue/Green. I liked all three....but I went with Bulbasaur...but, I wouldn't let it evolve higher than Ivysaur because Venosaur to me is just...ugly. Same with Blastoise. Charizard is okay. Gold/Silver...I chose Waninoko and I've never evolved it past that stage...although granted, I didn't care for either of the Gold/Silver starters.
Ruby/Sapphire I just couldn't get into the games in a general sense....but I think I chose the water starter.
Diamond/Pearl...same as Ruby/Sapphire...but if I had to choose, it would be Pochama, but I don't like the looks of its higher forms.
Black/White...I chose Mijumaru and haven't let him evolve higher than Futachimaru. It was tough to choose, though, as I liked the designs of all three. Pokabu is just too adorable!..but I only like the first forms. Didn't like the higher forms for neither Tsutaja or Pokabu.
For X/Y...Fokko was the only one I actually found cute...but I don't like the looks of its higher forms at all.
So yeah....it's all about looks for me. ^^ Oh and sorry about using the Japanese names. Outside of Gen I and II, I've had more exposure to the Japanese versions than their English versions.